-
Notifications
You must be signed in to change notification settings - Fork 227
Allow subclassing of SQLAlchemyObjectType without major API changes #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The pypy tests failed for some reason. Perhaps @syrusakbary can help me understand where the bug is (it looks like it's in your config script??…) |
The error is just in the python lint:
|
Awesome. Thanks for the heads up. Revised! |
@syrusakbary do you think this PR is viable? |
Yup! In Graphene |
When will this be put on pypi? |
This PR allows wholesale re-implementation of
SQLAlchemyObjectType
by revising the registry to ensure the classes are of typeSQLAlchemyObjectTypeMeta
, or subclassing SQLAlchemyObjectType (or a subclass thereof) by providingabstract = True
on the subclass's Meta.The docs have been updated to reflect this.
i.e.: